Fix issue with signature verification in JRuby #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are all passing. |
|
Looked like there was a conflict, so I resolved it and fixed the tests that started failing from the other merge. |
|
This is great, thanks. You beat me to it all. |
progrium
added a commit
that referenced
this pull request
Jul 20, 2012
Fix issue with signature verification in JRuby
|
BTW, since I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird discrepancy between how signatures are verified in JRuby and in all other Rubies. I've worked around this issue by adding a
begin..rescueblock to catch the extra exception that JRuby throws in some scenarios.Also updates the version number for release.
Any chance this could get pulled and released soonish? This error is wreaking havoc on our continuous build. :-/